Deprecate refresh call, revert old newsession impl "fix", fix tests

deephaven · Sep 19, 2022 · 046bdd2 · 046bdd2
1 parent 5a08142
commit 046bdd2
Show file tree

Hide file tree

Showing 12 changed files with 83 additions and 73 deletions.
diff --git a/go/internal/proto/session/session.pb.go b/go/internal/proto/session/session.pb.go
diff --git a/go/internal/proto/session/session_grpc.pb.go b/go/internal/proto/session/session_grpc.pb.go
diff --git a/proto/proto-backplane-grpc/src/main/proto/deephaven/proto/session.proto b/proto/proto-backplane-grpc/src/main/proto/deephaven/proto/session.proto
@@ -40,8 +40,13 @@ service SessionService {
   /*
    * Keep-alive a given token to ensure that a session is not cleaned prematurely. The response may include an updated
    * token that should replace the existing token for subsequent requests.
+   *
+   * Deprecated: Please use Flight's Handshake with an empty payload.
    */
-  rpc RefreshSessionToken(HandshakeRequest) returns (HandshakeResponse) {}
+  rpc RefreshSessionToken(HandshakeRequest) returns (HandshakeResponse) {
+    option deprecated = true;
+  }
+
 
   /*
    * Proactively close an open session. Sessions will automatically close on timeout. When a session is closed, all