Test for null result in DataIndexer.getOptimalPartialIndex (#5449)

deephaven · May 3, 2024 · 169d4eb · 169d4eb
1 parent 93d9268
commit 169d4eb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/engine/table/src/main/java/io/deephaven/engine/table/impl/indexer/DataIndexer.java b/engine/table/src/main/java/io/deephaven/engine/table/impl/indexer/DataIndexer.java
@@ -252,7 +252,7 @@ public static DataIndex getOptimalPartialIndex(Table table, final String... keyC
                 .filter(Objects::nonNull)
                 .max(Comparator.comparingLong(dataIndex -> dataIndex.table().size()))
                 .orElse(null),
-                table::isRefreshing, DataIndex::isRefreshing);
+                table::isRefreshing, (final DataIndex result) -> result != null && result.isRefreshing());
     }
 
     /**

diff --git a/engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableWhereTest.java b/engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableWhereTest.java
@@ -318,6 +318,15 @@ private void testWhereInDependencyInternal(
         }
     }
 
+    @Test
+    public void testWhereInOptimalIndexSelectionWithNoneAvailable() {
+        final Table lhs = emptyTable(10).update("Part=ii % 2 == 0 ? `Apple` : `Pie`", "Hello=ii", "Goodbye = `A`+ii");
+        DataIndexer.getOrCreateDataIndex(lhs, "Part");
+        final Table rhs = emptyTable(2).update("Hello=ii", "Goodbye = `A`+ii");
+        final Table result = lhs.whereIn(rhs, "Goodbye");
+        assertTableEquals(lhs.head(2), result);
+    }
+
     @Test
     public void testWhereDynamicIn() {
         final QueryTable setTable = testRefreshingTable(i(2, 4, 6, 8).toTracking(), col("X", "A", "B", "C", "B"));