Skip to content

Commit

Permalink
Add optional S3 dependency to py embedded-server (#5180)
Browse files Browse the repository at this point in the history
Also, adds overlooked sql and s3 to server-jetty-app-custom example.
  • Loading branch information
devinrsmith authored and stanbrub committed Feb 28, 2024
1 parent fc87685 commit 3fb6fd8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
4 changes: 4 additions & 0 deletions py/embedded-server/java-runtime/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ dependencies {
if (!hasProperty('excludeSql')) {
runtimeOnly project(':engine-sql')
}

if (!hasProperty('excludeS3')) {
runtimeOnly project(':extensions-s3')
}
}

// making a dir here isn't optimal, but without it we need to make py-embedded-server be a java and a python
Expand Down
12 changes: 12 additions & 0 deletions server/jetty-app-custom/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,18 @@ if (!hasProperty('excludeClockImpl')) {
extraJvmArgs += ['--add-exports', 'java.base/jdk.internal.misc=ALL-UNNAMED']
}

if (!hasProperty('excludeSql')) {
dependencies {
runtimeOnly project(':engine-sql')
}
}

if (!hasProperty('excludeS3')) {
dependencies {
runtimeOnly project(':extensions-s3')
}
}

if (hasProperty('devCerts') || hasProperty('devMTLS')) {
extraJvmArgs += [
'-Dhttp.port=8443',
Expand Down

0 comments on commit 3fb6fd8

Please sign in to comment.