Insist on terminating our CSV files with a line separator.

deephaven · Jun 12, 2024 · a5bf8fa · a5bf8fa
1 parent e2a1b9d
commit a5bf8fa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/extensions/csv/src/main/java/io/deephaven/csv/CsvTools.java b/extensions/csv/src/main/java/io/deephaven/csv/CsvTools.java
@@ -531,7 +531,6 @@ public static void writeCsv(Table[] sources, String destPath, boolean compressed
         }
 
         writeCsvHeader(out, fieldSeparator, columns);
-        out.write(System.lineSeparator());
 
         for (Table source : sources) {
             writeCsvContents(source, out, timeZone, null, nullsAsEmpty, fieldSeparator, columns);
@@ -647,6 +646,7 @@ public static void writeCsv(Table source, Writer out, ZoneId timeZone,
 
         writeCsvHeader(out, separator, columns);
         writeCsvContents(source, out, timeZone, progress, nullsAsEmpty, separator, columns);
+        out.write(System.lineSeparator());
 
         out.close();
     }

diff --git a/extensions/csv/src/test/java/io/deephaven/csv/TestCsvTools.java b/extensions/csv/src/test/java/io/deephaven/csv/TestCsvTools.java
@@ -272,7 +272,7 @@ public void testWriteCsv() throws Exception {
                                 parseZonedDateTime("2022-11-06T03:00:00.000000000 America/New_York")
                         },
                         new Boolean[] {
-                                null, false, true, true, false, false, false, false, true, false, null, null, true
+                                null, false, true, true, false, false, false, false, true, false, null, null, null
                         }
                 });
         final String[] casts = {