Skip to content

Commit

Permalink
Update publish-ci to continue on certain failures (#5191)
Browse files Browse the repository at this point in the history
There was an error observed during the v0.33.0 release where the deephaven-server artifact was too large for PyPi. There are other failure scenarios that we could potentially run into here as well - network connectivity, expired tokens, temporary service interruptions, etc. Given that all of the release artifacts have already been successfully uploaded as a GitHub artifact, we should prefer to continue with publishing to all the sources even if one of the sources fails.
  • Loading branch information
devinrsmith authored and stanbrub committed Feb 28, 2024
1 parent 21e39dc commit cd27d4d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/publish-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
user: __token__
password: ${{ secrets.DEEPHAVENCORE_PYPI_TOKEN }}
packages_dir: py/server/build/wheel/
continue-on-error: true

- name: Publish deephaven-server to PyPi
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
Expand All @@ -97,6 +98,7 @@ jobs:
user: __token__
password: ${{ secrets.DEEPHAVENSERVER_PYPI_TOKEN }}
packages_dir: py/embedded-server/build/wheel/
continue-on-error: true

- name: Publish pydeephaven to PyPi
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
Expand All @@ -105,9 +107,11 @@ jobs:
user: __token__
password: ${{ secrets.PYDEEPHAVEN_PYPI_TOKEN }}
packages_dir: py/client/build/wheel/
continue-on-error: true

- name: Publish @deephaven/jsapi-types to npmjs
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
env:
NODE_AUTH_TOKEN: ${{ secrets.DEEPHAVENBOT_NPM_TOKEN }}
run: npm publish --tag latest web/client-api/types/build/deephaven-jsapi-types-*.tgz
continue-on-error: true

0 comments on commit cd27d4d

Please sign in to comment.