Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support column preview grpc call #107

Closed
niloc132 opened this issue Mar 3, 2021 · 2 comments · Fixed by #1487
Closed

Support column preview grpc call #107

niloc132 opened this issue Mar 3, 2021 · 2 comments · Fixed by #1487
Assignees
Labels
Milestone

Comments

@niloc132
Copy link
Member

niloc132 commented Mar 3, 2021

Presently ColumnPreviewManager is always used to replace some columns which potentially aren't friendly for the UI - this is irritating to not be able to opt out of (yes a preview table has an attribute you can fetch, but wouldnt opt-in be nicer, esp for non-UI console commands)?

@nbauernfeind
Copy link
Member

Charles points out that maybe we shouldn't auto-to-string non-ipc friendly columns. It actually ties well with this issue (i.e. the "can't opt out") and it might otherwise be confusing that a column keeps showing up as a string when do you want to transfer structured content. It was a choice we had made to be friendlier to the UI.

@nbauernfeind nbauernfeind modified the milestones: June 2021, July 2021 Jul 26, 2021
@nbauernfeind
Copy link
Member

This is going to be addressed with Barrage Column Conversion modes. There are hooks in place, but no implementation yet: #936. Closing this ticket in favor of the other as it is less defined and less clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants