FetchTable: make apply preview columns optional #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
force-pushed
the
apply_prev_cols
branch
from
35b2ac3 to
3078952
Compare
niloc132
reviewed
Oct 27, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/table/ops/ApplyPreviewColumnsGrpcImpl.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/table/ops/ApplyPreviewColumnsGrpcImpl.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Show resolved
Hide resolved
niloc132
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to do it by using column conversion modes, but Colin told me that there is more going on here than toStringing columns.
Additionally, I wanted to be able to subscribe to the table directly (without further operations) from the jsapi; this enables that.
Fixes #107.