Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlightClient.doExchange reference impl requires an initial flight descriptor before payloads #1883

Closed
niloc132 opened this issue Jan 25, 2022 · 0 comments · Fixed by #1964
Closed

FlightClient.doExchange reference impl requires an initial flight descriptor before payloads #1883

niloc132 opened this issue Jan 25, 2022 · 0 comments · Fixed by #1964
Assignees
@lbooker42
Labels
arrow grpc
Milestone
Feb 2022

Comments

@niloc132
Copy link
Member

We have three DoExchange calls, subscribe, snapshot, and publish. While our app_metadata contents (BarrageMessageWrapper) already disambiguate as to what the stream will be for, FlightClient assumes that the initial FlightData consists only of a FlightDescriptor, and allows no other data to be passed by the client to the server.

While this initial message isn't necessary for deephaven clients, it would be nice to make it easy for flight clients to call these services in a consistent way.
@niloc132 niloc132 added this to the Feb 2022 milestone Jan 25, 2022
@lbooker42 lbooker42 linked a pull request Feb 10, 2022 that will close this issue
Increased compatibility with Flight reference implementation of DoExchange #1964
Merged
mofojed pushed a commit that referenced this issue Apr 4, 2024
@github-actions @deephaven-internal
Update web version 0.72.0 (#5330)
2d74d77 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.72.0

# [0.72.0](deephaven/web-client-ui@v0.71.0...v0.72.0) (2024-04-04)


### Bug Fixes

* Add isInvalid prop to Select component ([#1883](deephaven/web-client-ui#1883)) ([1803f31](deephaven/web-client-ui@1803f31)), closes [#1882](deephaven/web-client-ui#1882)
* adjust alignment of search input next/previous buttons ([#1917](deephaven/web-client-ui#1917)) ([c7fcd38](deephaven/web-client-ui@c7fcd38))
* Dashboard onLayoutInitialized not firing if config is empty ([#1914](deephaven/web-client-ui#1914)) ([84c648b](deephaven/web-client-ui@84c648b))
* package-lock missing pinned dependency ([#1920](deephaven/web-client-ui#1920)) ([1d9d216](deephaven/web-client-ui@1d9d216))


### Code Refactoring

* Change embed-grid and embed-chart to redirects ([#1873](deephaven/web-client-ui#1873)) ([e17619a](deephaven/web-client-ui@e17619a))


### Features

* Picker - formatter settings ([#1907](deephaven/web-client-ui#1907)) ([f06a141](deephaven/web-client-ui@f06a141)), closes [#1889](deephaven/web-client-ui#1889)
* re-export spectrum useStyleProp util ([#1916](deephaven/web-client-ui#1916)) ([aafa14b](deephaven/web-client-ui@aafa14b))
* wrap spectrum View, Text and Heading to accept custom colors ([#1903](deephaven/web-client-ui#1903)) ([a03fa07](deephaven/web-client-ui@a03fa07))


### BREAKING CHANGES

* `@deephaven/embed-grid` does not handle messages to the
iframe for filtering or sorting the grid any more





Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbooker42 lbooker42

Labels
arrow grpc
Projects
None yet
Milestone
Feb 2022
Development

Successfully merging a pull request may close this issue.

Increased compatibility with Flight reference implementation of DoExchange lbooker42/deephaven-core
2 participants
@niloc132 @lbooker42