Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish .proto files #2840

Closed
JamesXNelson opened this issue Sep 12, 2022 · 0 comments · Fixed by #2844
Closed

Publish .proto files #2840

JamesXNelson opened this issue Sep 12, 2022 · 0 comments · Fixed by #2844
Assignees
@niloc132
Labels
build feature request New feature or request
Milestone
Sept 2022

Comments

@JamesXNelson
Copy link
Member

As a consumer of Deephaven code, I want a jar published with all Deephaven .proto files in it, so that I can use command-line tools like grpcurl, or build my own proto-implementations of Deephaven APIs in my language of choice.
@JamesXNelson JamesXNelson added feature request New feature or request triage labels Sep 12, 2022
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Sep 13, 2022
@niloc132
Package proto files in the top level of the jar based on them
7bc36da 
This follows the pattern in use by flight-core with its Flight.proto
file.

Fixes deephaven#2840
@niloc132 niloc132 mentioned this issue Sep 13, 2022
Merged
@niloc132 niloc132 self-assigned this Sep 13, 2022
@niloc132 niloc132 added this to the Sept 2022 milestone Sep 13, 2022
@niloc132 niloc132 added build and removed triage labels Sep 13, 2022
niloc132 added a commit that referenced this issue Sep 15, 2022
@niloc132
Package proto files in the top level of the jar based on them (#2844)
732ed30 
This follows the pattern in use by flight-core with its Flight.proto
file.

Fixes #2840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
build feature request New feature or request
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging a pull request may close this issue.

Package proto files in the top level of the jar based on them niloc132/deephaven-core
2 participants
@niloc132 @JamesXNelson