Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryCompiler collision issues? #2949

Closed
rcaudy opened this issue Oct 5, 2022 · 0 comments · Fixed by #2962
Closed

QueryCompiler collision issues? #2949

rcaudy opened this issue Oct 5, 2022 · 0 comments · Fixed by #2962
Assignees
Labels
bug Something isn't working query engine
Milestone

Comments

@rcaudy
Copy link
Member

rcaudy commented Oct 5, 2022

See:
https://gitlab.deephaven.io/illumon/iris/-/merge_requests/6879/diffs

We should reproduce and port the fix if appropriate. It's apparently easy to repro by changing the packageNameSuffix calculation, as in:

final String packageNameSuffix = "c" + pi + "v" + JAVA_CLASS_VERSION;

Note that the improved hash in the code to port is not an essential part of the fix, it just reduces the probability of collisions. The key is not allowing a duplicate result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working query engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants