QueryCompiler: Use SHA-256 hash instead of String#hashCode on class body #2962

nbauernfeind · 2022-10-05T22:09:47Z

Fixes #2949.

engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java

Util/src/main/java/io/deephaven/util/ByteUtils.java

Co-authored-by: Ryan Caudy <rcaudy@gmail.com>

devinrsmith · 2022-10-07T17:14:49Z

I tried to remove myself as a reviewer, but I'm not sure I can? Anyways, leaving for Ryan.

QueryCompiler: Use SHA-256 hash instead of String#hashCode on class body

c5507b5

nbauernfeind added bug Something isn't working query engine NoDocumentationNeeded labels Oct 5, 2022

nbauernfeind added this to the Oct 2022 milestone Oct 5, 2022

nbauernfeind requested a review from rcaudy October 5, 2022 22:09

nbauernfeind self-assigned this Oct 5, 2022

nbauernfeind force-pushed the query_compiler_sha256 branch from 6dc850c to c5507b5 Compare October 5, 2022 22:23

devinrsmith reviewed Oct 5, 2022

View reviewed changes

engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java Outdated Show resolved Hide resolved

rcaudy requested changes Oct 6, 2022

View reviewed changes

nbauernfeind and others added 2 commits October 6, 2022 20:50

Update Util/src/main/java/io/deephaven/util/ByteUtils.java

ebc6ebf

Co-authored-by: Ryan Caudy <rcaudy@gmail.com>

Rewrite based on review

4aff683

nbauernfeind requested review from rcaudy and devinrsmith October 7, 2022 02:57

revert signed shift change; it is incorrect

7910c41

devinrsmith removed their request for review October 7, 2022 17:14

rcaudy approved these changes Oct 7, 2022

View reviewed changes

nbauernfeind merged commit 58ec970 into deephaven:main Oct 10, 2022

github-actions bot locked and limited conversation to collaborators Oct 10, 2022

Provide feedback