SERVER: subscribeToLogs RPC does not respond to session cancellation #5415
Comments
|
Likely introduced in #3379 due to the move away from |
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
Apr 26, 2024
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
Apr 26, 2024
|
ObjectService.messageStream has a similar issue |
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
Apr 30, 2024
This PR fixes subscribeToLogs and messageStream RPCs; previously, they were staying open when a Session closed. Session closing behavior for a number of RPCs was specifically added as a tests here. I'll note that we are inconsistent in how we handle this case - some RPCs will complete successfully, others will pass along UNAUTHENTICATED or CANCELLED. We should aim to clean this up, but I'm proposing we do that as a follow-up PR to avoid PR bloat. The fix involves hooking into SessionServiceCallListener, which is a centralized place where we maintain Session state information. We should strongly consider migrating other RPC Session close behavior to here to simplify the implementations and maintain consistency. Again, I'd suggest doing that as a separate PR. Fixes deephaven#5415
devinrsmith
added a commit
that referenced
this issue
May 15, 2024
…#5433) This PR fixes subscribeToLogs and messageStream RPCs; previously, they were staying open when a Session closed. Session closing behavior for a number of RPCs was specifically added as a tests here. I'll note that we are inconsistent in how we handle this case - some RPCs will complete successfully, others will pass along UNAUTHENTICATED or CANCELLED. We should aim to clean this up, but I'm proposing we do that as a follow-up PR to avoid PR bloat. The fix involves hooking into SessionServiceCallListener, which is a centralized place where we maintain Session state information. We should strongly consider migrating other RPC Session close behavior to here to simplify the implementations and maintain consistency. Again, I'd suggest doing that as a separate PR. Fixes #5415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During an audit of client / server behavior wrt
Session#close,ManagedChannel#shutdown/Now, it was observed that the server implementaion of subscribeToLogs allows the RPCs for closed sessions to remain indefinitely. This is in contrast to a similar listFields RPC with does register itself withSessionState#addOnCloseCallback.The text was updated successfully, but these errors were encountered: