Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables created from application state do not re-hydrate correctly: Cannot create a VariableDefinition from a non-scope ticket #5434

Closed
mofojed opened this issue Apr 2, 2024 · 1 comment · Fixed by #5435
Assignees
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Apr 2, 2024

Description

When you open a panel that's created in the app state, and then re-fresh the browser, the panel does not re-open correctly.

Steps to reproduce

  1. Create an application that sets variables in the app state:
from deephaven import empty_table
from deephaven.appmode import get_app_state

get_app_state()['my_app_table'] = empty_table(10).update("x=i-5")
  1. From the Web UI, open the panel my_app_table from the Panels menu
  2. Refresh the browser

Expected results
3. Panel should stay open

Actual results

  1. Error message displayed in panel: Unable to open table. Error: java.lang.IllegalArgumentException: Cannot create a VariableDefinition from a non-scope ticket

Additional details and attachments

image

Versions

Engine Version: 0.34.0-SNAPSHOT
Web UI Version: 0.71.0
Java Version: 11.0.21
Barrage Version: 0.6.0
Browser Name: Chrome 123
OS Name: macOS 10.15.7

@mofojed mofojed added bug Something isn't working triage labels Apr 2, 2024
@vbabich vbabich removed the triage label Apr 2, 2024
@mofojed mofojed self-assigned this Apr 15, 2024
@mofojed mofojed assigned mofojed and unassigned mofojed Apr 24, 2024
@mofojed
Copy link
Member Author

mofojed commented Apr 30, 2024

Caused by the fixes for 5fab992#diff-4952aaa86441533bdc7e5f6e3d553e5d00dcc67bd133a1bae6f4f468fd5a525b
In particular, a check was added to JsVariableDefinition creation that rejects if the base64 ID does not match a specific format:

In application variable cases, it starts with a/. But I don't know what other formats there could be. Do we really need that check?

@mofojed mofojed transferred this issue from deephaven/web-client-ui Apr 30, 2024
@mofojed mofojed linked a pull request May 3, 2024 that will close this issue
@mofojed mofojed closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants