Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Could not re-open application created variables #5435

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Apr 30, 2024

  • Passing in a VariableDescriptor with a valid ID was not creating a proper VariableDefinition
  • It's checking "s/" specifically, whereas application variable is prefixed with "a/"
  • Tested by following the steps in the description.

- Passing in a VariableDescriptor with a valid ID was not creating a proper VariableDefinition
- It's checking "s/" specifically, whereas application variable is prefixed with "a/"
- Tested by following the steps in the description.
@mofojed mofojed added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Apr 30, 2024
@mofojed mofojed requested a review from niloc132 April 30, 2024 14:26
@mofojed mofojed self-assigned this Apr 30, 2024
@mofojed mofojed merged commit 96a4086 into deephaven:main Apr 30, 2024
19 checks passed
@mofojed mofojed deleted the 5434-application-variables branch April 30, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants