-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to add column groups past some unknown limit #5627
Comments
This seems to be an engine/JS API issue. I just checked and The table has the right attribute Number of columns also seems like it's not a direct culprit. I changed to groups of 5 and it only displays 19 groups or 95 columns worth compared to 120 in the example w/ 10. from deephaven.pandas import to_table
import pandas as pd
columns = [f"col{i}" for i in range(250)]
column_groups = [{"name":f"group_{i}", "children":[f"col{i}" for i in range(i*5, (i+1)*5)]} for i in range(50)]
N_COLUMNS = len(columns)
N_ROWS = 100
zeros = [ [0] * N_COLUMNS for _ in range(N_ROWS)]
table = to_table(pd.DataFrame(zeros, columns=columns))
test1 = table.layout_hints(column_groups = column_groups) # no groups
test2 = table.layout_hints(column_groups = column_groups[:20]) # no groups, same for any value bigger than 20
test3 = table.layout_hints(column_groups = column_groups[:19]) # works |
When There is however an "unsent" attribute for LayoutHints set: Looks like we have a cap for how long a table attribute can be before we don't include it: https://github.com/deephaven/deephaven-core/blob/main/extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java#L106 Unsure why that limit was picked, possible we can just bump it up a bit... though there will still be some limit. When we wire up layout hints through ui.table, we shouldn't have this same limitation. |
- Copied over from DHE days - No need to have a limit on this anymore - Tested with the snippet in the ticket - Fixes deephaven#5627
- Copied over from DHE days - No need to have a limit on this anymore - Tested with the snippet in the ticket - Fixes deephaven#5627
Description
Trying to create a large table with a lot of columns and column groups stops working after a certain point.
Steps to reproduce
Expected results
test2
should appear with 13 column groups of 10 columns eachActual results
test2
appears, but no column groups are visible.Additional details and attachments
Versions
Engine Version: 0.35.0-SNAPSHOT
Web UI Version: 0.82.0
Java Version: 11.0.23
Barrage Version: 0.6.0
Browser Name: Chrome 125
OS Name: Linux
@deephaven/js-plugin-plotly-express: 0.4.0
@deephaven/js-plugin-ui: 0.15.0
@deephaven/js-plugin-ag-grid: 0.1.0
The text was updated successfully, but these errors were encountered: