Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.slf4j:slf4j-api 1.x on classpath breaks logging #5642

Closed
devinrsmith opened this issue Jun 20, 2024 · 0 comments · Fixed by #5590
Closed

org.slf4j:slf4j-api 1.x on classpath breaks logging #5642

devinrsmith opened this issue Jun 20, 2024 · 0 comments · Fixed by #5590
Assignees
@lbooker42
Labels
bug Something isn't working dependencies Pull requests that update a dependency file release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Milestone
3. May 2024

Comments

@devinrsmith
Copy link
Member

#5277 introduced org.apache.iceberg:iceberg-aws-bundle into our classpath; this had the effect of implicitly including org.slf4j:slf4j-api 1.x, which was internally included in the iceberg-aws-bundle.jar (see apache/iceberg#10534).

While libraries that use slf4j-api 1.x can use 2.x, the inverse in not true https://www.slf4j.org/faq.html#compatibility. Given that DH depends on 2.x (ServiceLoader configuration logic, https://www.slf4j.org/faq.html#changesInVersion200), we fail to configure logging correctly if slf4j-api 1.x is loaded.
@devinrsmith devinrsmith added bug Something isn't working release blocker A bug/behavior that puts is below the "good enough" threshold to release. dependencies Pull requests that update a dependency file labels Jun 20, 2024
@devinrsmith devinrsmith added this to the 3. May 2024 milestone Jun 20, 2024
This was referenced Jun 20, 2024
Open
Merged
@devinrsmith devinrsmith linked a pull request Jun 20, 2024 that will close this issue
feat: expose Iceberg features to python users #5590
Merged
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Jun 20, 2024
@devinrsmith
Change py-embedded-server from WARN to INFO logging
8044e75 
The python embedded Deephaven server does not currently show the end-user any INFO logging. It was stated that the default was WARN so that the end-user doesn't get command line spam, but that is already covered in the setup - the slf4j / logback logging does _not_ hit the terminal regardless. This is only applicable for logging that hits the web UI via LogBufferAppender / ConsoleService.SubscribeToLogs.

Note: this should merge after deephaven#5642 is fixed.
@devinrsmith devinrsmith mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbooker42 lbooker42

Labels
bug Something isn't working dependencies Pull requests that update a dependency file release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Projects
None yet
Milestone
3. May 2024
Development

Successfully merging a pull request may close this issue.

feat: expose Iceberg features to python users lbooker42/deephaven-core
2 participants
@lbooker42 @devinrsmith