perf: Remove unused naturalJoin key states. #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpwright
changed the title
cpwright
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
added
ReleaseNotesNeeded
rcaudy
reviewed
Jul 16, 2024
...ava/io/deephaven/engine/table/impl/by/typed/incopenagg/gen/IncrementalAggOpenHasherChar.java
Show resolved
Hide resolved
...a/io/deephaven/engine/table/impl/asofjoin/typed/staticopen/gen/StaticAsOfJoinHasherChar.java
Show resolved
Hide resolved
...en/engine/table/impl/asofjoin/typed/rightincopen/gen/RightIncrementalAsOfJoinHasherChar.java
Show resolved
Hide resolved
.../java/io/deephaven/engine/table/impl/by/typed/staticopenagg/gen/StaticAggOpenHasherChar.java
Show resolved
Hide resolved
.../deephaven/engine/table/impl/multijoin/typed/incopen/gen/IncrementalMultiJoinHasherChar.java
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jul 19, 2024
.../table/src/main/java/io/deephaven/engine/table/impl/by/ChunkedOperatorAggregationHelper.java
Show resolved
Hide resolved
...engine/table/impl/by/IncrementalChunkedOperatorAggregationStateManagerOpenAddressedBase.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
...phaven/engine/table/impl/naturaljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java
Outdated
Show resolved
Hide resolved
…raljoin/IncrementalNaturalJoinStateManagerTypedBase.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
…raljoin/typed/incopen/gen/IncrementalNaturalJoinHasherChar.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
reviewed
Jul 20, 2024
rcaudy
approved these changes
Jul 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated hash tables for naturalJoin (and other operations) never removed a bucket's hash table entry when it became entry. For cases where a naturalJoin cycles through buckets, the hash table could be filled with empty values consuming memory without reason.
This changes the generated open addressed hash table for both-sides incremental naturalJoin to mark entries deleted with a tombstone when both the left and right side are empty. The occupancy of the hash table for use in load factor computation includes the number of entries in the hash table and tombstones. The rehash operation may copy entries into a new table that is the same size as the original table instead of always doubling in size, allowing tombstone entries to be reaped.
Closes #5769