fix: Ensure that most TableListener/MergedListener Notifications are processed while ensuring liveness; improve timeout handling in Table.awaitUpdate #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
added
query engine
core
rcaudy
changed the title
…ow run the actual notification processing work while guaranteeing that they remain live for the duration
… TimeSeriesFilters from previous validation rounds
…e don't report spurious double-notifies if a notification runs after destroy caused a prior notification to be skipped
rcaudy
force-pushed
the
rwc-listenerliveness
branch
from
8e7117b to
f28e9e2
Compare
cpwright
reviewed
Nov 23, 2024
| return false; | ||
| } | ||
| timeoutMillis -= TimeUnit.MILLISECONDS.convert(System.nanoTime() - startTime, TimeUnit.NANOSECONDS); | ||
|
|
There was a problem hiding this comment.
I would check for timeoutMillis <= 0 and bail (or clamp it). I see no javadoc for the await call on Condition, but the standard wait call has the note:
In all respects, this method behaves as if wait(0L, 0) had been called. See the specification of the wait(long, int) method for details.
That has bit some of the Enterprise gRPC timeout handling in the past.
Which points out that if you have a zero argument, you are going to wait forever. I would prefer to have a check within the try to be very explicit about that edge case.
|
Back to draft/WIP, trying to expand the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.