Properly use liveness API for dynamic non-refreshing nodes in SessionState exports #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
rcaudy
reviewed
Aug 20, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/arrow/ArrowFlightUtil.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionState.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionState.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionState.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
static_table_race
branch
from
ad3c611
to
fc87700
Compare
nbauernfeind
changed the title
rcaudy
previously approved these changes
Aug 21, 2021
nbauernfeind
force-pushed
the
static_table_race
branch
from
fc87700
to
7f2f454
Compare
rcaudy
approved these changes
Aug 21, 2021
niloc132
added a commit
to niloc132/deephaven-core
that referenced
this pull request
Aug 24, 2021
… SessionState exports (deephaven#1092)" This reverts commit 87aa98e.
kosak
pushed a commit
to kosak/deephaven-core
that referenced
this pull request
Aug 31, 2021
… SessionState exports (deephaven#1092)" This reverts commit 87aa98e.
kosak
pushed a commit
to kosak/deephaven-core
that referenced
this pull request
Aug 31, 2021
… SessionState exports (deephaven#1092)" This reverts commit 87aa98e.
kosak
pushed a commit
to kosak/deephaven-core
that referenced
this pull request
Aug 31, 2021
… SessionState exports (deephaven#1092)" This reverts commit 87aa98e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query:
Would display the first page, but any viewport changes would throw an exception due to incorrect usage of LivenessReferent API. It was easily triggered using SSL, could not reproduce using the grpc-web proxy.