Upgrade javaparser-core to 3.23.0 #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
force-pushed
the
java_parser_3_22_1
branch
from
81d250d
to
b539975
Compare
rcaudy
reviewed
Aug 26, 2021
DB/src/main/java/io/deephaven/db/v2/TreeTableOrphanPromoter.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageParser.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageParser.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageParser.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/shadow/javaparser/com/github/javaparser/ExpressionParser.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Aug 27, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/table/validation/ColumnExpressionValidator.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/shadow/javaparser/com/github/javaparser/ExpressionParser.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/shadow/javaparser/com/github/javaparser/ExpressionParser.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/shadow/javaparser/com/github/javaparser/ExpressionParser.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageParser.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
java_parser_3_22_1
branch
from
b539975
to
ac058a0
Compare
nbauernfeind
changed the title
nbauernfeind
force-pushed
the
java_parser_3_22_1
branch
from
ac058a0
to
2373cb7
Compare
rcaudy
previously approved these changes
Aug 27, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/table/validation/ColumnExpressionValidator.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/table/validation/ColumnExpressionValidator.java
Outdated
Show resolved
Hide resolved
| expr.accept(new ColumnExpressionValidator(), null); | ||
| //now that we finally have the AST... | ||
| //check method and constructor calls that weren't already checked | ||
| if (!result.isSuccessful()) { |
There was a problem hiding this comment.
Can this actually happen without throwing a PPE?
nbauernfeind
force-pushed
the
java_parser_3_22_1
branch
from
157bf95
to
29f88c3
Compare
rcaudy
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to use a dependency that requires a more modern version of javaparser.
This PR upgrades javaparser from 2.0.0 to 3.23.0. (Yay! 🥳)
Note that the nightly CI actions pass.
Fixes #1070