Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Kafka python tests. #1155

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Conversation

jcferretti
Copy link
Member

This PR has a single test, intended to verify/agree on the way to setup things in gradle for the integration with redpanda.
More tests will be added in a separate PR later, which allows the review burden and the bandwidth requirement for different people to be controlled.

@jcferretti jcferretti merged commit cf19dfa into deephaven:main Aug 30, 2021
@jcferretti jcferretti deleted the cfs-kafka-py-test-0 branch August 30, 2021 20:00
@devinrsmith
Copy link
Member

devinrsmith commented Aug 30, 2021

I think we need to add in hooks for

composeDown task stops the application and removes the containers, only if 'stopContainers' is set to 'true' (default value).

?

@jcferretti
Copy link
Member Author

jcferretti commented Aug 30, 2021

Answering Devin above, we discussed via slack:

From the Usage section in the README.md, in the example code:

dockerCompose.isRequiredBy(test) // hooks 'dependsOn composeUp' and 'finalizedBy composeDown', and exposes environment variables and system properties (if possible)

So, this is already happening, we should be good as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants