Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate query scope changes even if script throws a RuntimeError #1191

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Sep 1, 2021

The failing example looks like:

from deephaven import TableTools
x = TableTools.emptyTable(10)
y = x.update("I = jj")

Followed by the corrected version of the script:

from deephaven import TableTools
x = TableTools.emptyTable(10)
y = x.update("I = ii")

Which caused an NPE since the listener is receiving the message that x is being updated, but it was never told about it in the first place. Note that the listener expects that an update is actually an update to a field it knows about. The python session can't tell where x came from during the second call.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to capture this eventually as an integration test of sorts.

@devinrsmith devinrsmith merged commit b5a36cc into deephaven:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants