Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md based on user feedback #1335

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Update CONTRIBUTING.md based on user feedback #1335

merged 3 commits into from
Sep 22, 2021

Conversation

chipkent
Copy link
Member

Update CONTRIBUTING.md to:

  1. Cover building from source code
  2. Cover how to interact with git on GitHub.

@chipkent chipkent added documentation Improvements or additions to documentation NoDocumentationNeeded labels Sep 21, 2021
@chipkent chipkent added this to the Sept 2021 milestone Sep 21, 2021
@chipkent chipkent self-assigned this Sep 21, 2021
margaretkennedy
margaretkennedy reviewed Sep 21, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@dsmmcken dsmmcken mentioned this pull request Sep 21, 2021
Closed
@chipkent chipkent merged commit 16ccc13 into deephaven:main Sep 22, 2021
@chipkent chipkent deleted the chipkent-update-contributing branch December 7, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaretkennedy margaretkennedy margaretkennedy approved these changes

@AlSpinks AlSpinks Awaiting requested review from AlSpinks

Assignees

@chipkent chipkent

Labels
documentation Improvements or additions to documentation NoDocumentationNeeded
Projects
None yet
Milestone
Sept 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@chipkent @margaretkennedy