Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User visible API for publishing to Kafka. #1377

Merged
merged 67 commits into from
Oct 29, 2021
Merged

User visible API for publishing to Kafka. #1377

merged 67 commits into from
Oct 29, 2021

Conversation

jcferretti
Copy link
Member

No description provided.

@jcferretti jcferretti added this to the Sept 2021 milestone Sep 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jcferretti
Copy link
Member Author

This was created as a branch over Charles' branch cpwright:cpw_publishToTable for #1344, so it contains his same base code except for changes to KafkaTools.java. I haven't done anything yet (as of me writing this comment) about python except for keeping the consume part of the refactoring working; ie, there is no produce part yet.

@jcferretti
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@jcferretti jcferretti self-assigned this Oct 19, 2021
@jcferretti jcferretti removed the request for review from cpwright October 20, 2021 19:40
@cpwright
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

rcaudy
rcaudy reviewed Oct 29, 2021
View reviewed changes
Kafka/src/main/java/io/deephaven/kafka/KafkaTools.java Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/KafkaTools.java Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/KafkaTools.java Outdated Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/KafkaTools.java Outdated Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/KafkaTools.java Outdated Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/publish/GenericRecordKeyOrValueSerializer.java Outdated Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/publish/GenericRecordKeyOrValueSerializer.java Outdated Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/publish/GenericRecordKeyOrValueSerializer.java Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/publish/JsonKeyOrValueSerializer.java Outdated Show resolved Hide resolved
Kafka/src/main/java/io/deephaven/kafka/publish/JsonKeyOrValueSerializer.java Outdated Show resolved Hide resolved
@rcaudy rcaudy modified the milestones: Sept 2021, Oct 2021 Oct 29, 2021
@rcaudy rcaudy merged commit 10fe4ce into deephaven:main Oct 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
@jcferretti jcferretti deleted the cfs_publishToTable_API branch February 18, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@jcferretti jcferretti

Labels
DocumentationNeeded kafka
Projects
None yet
Milestone
Oct 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@jcferretti @cpwright @rcaudy