Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the client and server pydocs the same #1392

Merged
merged 11 commits into from
Oct 6, 2021

Conversation

chipkent
Copy link
Member

@chipkent chipkent commented Oct 5, 2021

The client and server pydocs were not formatted the same. This resolves the inconsistencies.

The best features were taken from both the client and server docs. Source code and parameter types were taken from the client API, and the isolated module layout was taken from the server API.

@chipkent chipkent added this to the Oct 2021 milestone Oct 5, 2021
@chipkent chipkent self-assigned this Oct 5, 2021
sphinx/sphinx.gradle Outdated Show resolved Hide resolved
sphinx/sphinx.gradle Outdated Show resolved Hide resolved
sphinx/sphinx.gradle Outdated Show resolved Hide resolved
sphinx/sphinx.gradle Outdated Show resolved Hide resolved
@chipkent chipkent requested a review from niloc132 October 5, 2021 22:01
sphinx/lib/dh_sphinx.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver self-requested a review October 6, 2021 19:53
@chipkent chipkent merged commit 709bf62 into deephaven:main Oct 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
@chipkent chipkent deleted the format_pydoc_client branch December 7, 2021 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants