Docker tasks should always tell gradle if they have changes #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there was no copyOut, a docker task would not declare any outputs, so downstream tasks would not know if they had to re-run. This change explicitly marks the built image as the output, and logs a message in case an entrypoint running despite its output being ignored. Fixes deephaven#1408
jmao-denver
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there was no copyOut, a docker task would not declare any
outputs, so downstream tasks would not know if they had to re-run. This
change explicitly marks the built image as the output, and logs a
message in case an entrypoint running despite its output being ignored.
Fixes #1408