More friendly utility methods for arrow::Status and arrow::Result #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kosak
commented
Oct 15, 2021
kosak
commented
- Rename (statusOrDie, valueOrDie) to (okOrThrow, valueOrThrow)
- Introduce a helper macro to help generate informative "message@file:line" messages.
- Make informative messages optional.
* Rename (statusOrDie, valueOrDie) to (okOrThrow, valueOrThrow) * Introduce a helper macro to help generate informative "message@file:line" messages. * Make informative messages optional.
|
I was vacillating between two ways of doing this: the way presented here and another way which wrapped up (value, message, file, line) in a little helper object. This way is a tad simpler, and the other way is a tad more structured. We can discuss if you have an opinion. |
jcferretti
approved these changes
Oct 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.