[jsapi] Set rollback to null to enable orphan cleanup #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, rollbacks were not nulled out, in an attempt to avoid losing useful information as the table transitioned between states. Bug reports that applied to these old changes were used to test this commit; this does not alter their behavior (though I could not test the dashboard related bug).
Now, when an operation reaches a terminal state, its rollback should be cleared so that it is eligible for cleanup if it ever becomes an orphan.
While testing I also came across an additional CTS assertion error. Failed requests must not attempt to set their client state as running. If a table reaches a terminal state, it must always have its rollback nulled out, to avoid leaking the rollback.
Minor test change to
table_basic.htmlto use global variables so that they are easily accessible from the developer console.Fixes #1471