Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Arrow 6.0.1 #1498

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Upgrade to Arrow 6.0.1 #1498

merged 3 commits into from
Jan 25, 2022

Conversation

nbauernfeind
Copy link
Member

Need to run through some more formal testing; looking to merge this after release.

@nbauernfeind nbauernfeind added this to the Nov 2021 milestone Oct 28, 2021
@nbauernfeind nbauernfeind self-assigned this Oct 28, 2021
@pete-petey pete-petey modified the milestones: Nov 2021, Jan 2022 Dec 29, 2021
@nbauernfeind nbauernfeind changed the title Upgrade to Arrow 6.0.0 Upgrade to Arrow 6.0.1 Jan 20, 2022
@nbauernfeind nbauernfeind marked this pull request as ready for review January 20, 2022 17:02
@devinrsmith devinrsmith self-requested a review January 20, 2022 18:49
devinrsmith
devinrsmith previously approved these changes Jan 20, 2022
@devinrsmith
Copy link
Member

Should we look into upgrading pyarrow too?

Couple places in the source:

pyclient/requirements.txt, pyclient/build.gradle, sphinx/sphinx.gradle

@jmao-denver the versions also seem to not be the same.

@jmao-denver
Copy link
Contributor

jmao-denver commented Jan 20, 2022

It is definitely a good idea to upgrade and make all versions the same. IMO, upgrade of Arrow version should apply to the server and all the clients if possible. @nbauernfeind I don't think we need a separate ticket for the clients, your thoughts?

@nbauernfeind
Copy link
Member Author

@jmao-denver can't think of a good reason not to update them all at once. Updating now to kick off that CI build.

@nbauernfeind nbauernfeind merged commit 62f35c0 into deephaven:main Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants