Update redpanda version and enable embedded schema registry. #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add examples using it.
niloc132
reviewed
Nov 19, 2021
| KAFKA_BOOTSTRAP_SERVERS: redpanda:9092 | ||
| APPLICATION_ID: registry_id | ||
| APPLICATION_SERVER: localhost:9000 | ||
| - 8081 |
There was a problem hiding this comment.
personal opinion, stop using docker-compose for the test if we can, the plugin is not great, and i think we'll be happier to just do plain docker commands.
this isnt a requirement for merge or even a follow up, just a preference
There was a problem hiding this comment.
I hear you and makes sense but that is a non-trivial amount of work, so not doing it on this pass.
devinrsmith
approved these changes
Nov 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.