Configure cache dir #1712
Merged
Configure cache dir #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Dec 16, 2021
| deephaven.console.type=groovy | ||
| deephaven.cache.dir=/cache | ||
| java.io.tmpdir=/cache/tmp |
There was a problem hiding this comment.
Can we make this a sub-dir of the host's /tmp?
| private static final Path cacheDir; | ||
|
|
||
| static { | ||
| final String deephavenCacheDir = System.getProperty(DEEPHAVEN_CACHE_DIR); |
There was a problem hiding this comment.
Configuration.getInstance().getPropertyWithDefault?
There was a problem hiding this comment.
^ this is not an existing method. But I can use Configuration, sure.
There was a problem hiding this comment.
Sorry, method is io.deephaven.configuration.PropertyFile#getStringWithDefault.
| @@ -61,7 +60,7 @@ protected AbstractScriptSession(@Nullable Listener changeListener, boolean isDef | |||
| this.changeListener = changeListener; | |||
|
|
|||
| final UUID scriptCacheId = UuidCreator.getRandomBased(); | |||
| classCacheDirectory = new File(CLASS_CACHE_LOCATION, UuidCreator.toString(scriptCacheId)); | |||
| classCacheDirectory = CLASS_CACHE_LOCATION.resolve(UuidCreator.toString(scriptCacheId)).toFile(); | |||
There was a problem hiding this comment.
We discussed introducing props:
INSTANCE_ID (if set, this is the ID)
INSTANCE_ID_FILE (if set and INSTANCE_ID isn't this is the file we load from or generate)
else, we randomly allocate an instance ID and be sure to clean up on exit.
rcaudy
previously approved these changes
Dec 17, 2021
rcaudy
approved these changes
Dec 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be writing to a container's
/tmpdirectory in docker, unless it's a docker volume.Our docker images declare a
/cachevolume, so we should:-Djava.io.tmpdir=/cache/tmpso that any java code using temporary files will inherit a docker volume backed tmp space-Ddeephaven.cache.dirso that those who want more explicit "cache" space (instead of "tmp" space), can take advantage of it. (OnlyAbstractScriptSessionatm, but others could use it in the future.)