Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReAvg/ReVar in rollups violates new unordered destination assumption. #1739

Merged
merged 10 commits into from
Dec 28, 2021
Merged

ReAvg/ReVar in rollups violates new unordered destination assumption. #1739

merged 10 commits into from
Dec 28, 2021

Conversation

cpwright
Copy link
Contributor

No description provided.

@cpwright cpwright requested a review from rcaudy December 24, 2021 00:50
@cpwright cpwright marked this pull request as ready for review December 24, 2021 03:15
rcaudy
rcaudy reviewed Dec 28, 2021
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments/questions, except one operator that needs to be corrected.

engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedReAvgOperator.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/IntegralChunkedReAvgOperator.java Outdated Show resolved Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/BigIntegerChunkedReAvgOperator.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedReAvgOperator.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedReAvgOperator.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/FloatChunkedReAvgOperator.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/ReAvgVarOrderingContext.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/ReAvgVarOrderingContext.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/ReAvgVarOrderingContext.java Outdated Show resolved Hide resolved
rcaudy
rcaudy previously approved these changes Dec 28, 2021
View reviewed changes
@rcaudy rcaudy merged commit 09f21cd into deephaven:main Dec 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2021
@cpwright cpwright deleted the nightly/cpw_reavgvarordering branch December 28, 2021 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees
No one assigned
Labels
bug Something isn't working NoDocumentationNeeded query engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpwright @rcaudy