Add commented out debugging settings to docker-compose-common, to ease out turning debugging on. #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
reviewed
Jan 7, 2022
There was a problem hiding this comment.
I don't think we can remove -Xmx from our dev configuration and have it just work across all our dev environments, there are some caveats that may depend on docker engine version and OS cgroup version.
For production configurations in environments that are known in advance, I think this is a good change.
Chatting offline.
jcferretti
changed the title
devinrsmith
reviewed
Jan 7, 2022
docker-compose-common.yml
Outdated
| @@ -26,6 +28,7 @@ services: | |||
| resources: | |||
| limits: | |||
| cpus: '4.0' | |||
| # The JVM memory is configured from gradle to use *RAMPercentage options. | |||
There was a problem hiding this comment.
This comment doesn't make sense here anymore
devinrsmith
previously approved these changes
Jan 7, 2022
devinrsmith
approved these changes
Jan 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.