Added AggFormula in io.deephaven.api.agg.Aggregation, fixes #1699 #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also made it avaiable in deephaven2 via the agg.py wrapper
devinrsmith
previously approved these changes
Jan 10, 2022
pyintegration/tests/test_table.py
Outdated
| @@ -283,7 +284,6 @@ def test_agg_by_2(self): | |||
| weighted_avg("var", ["weights"])] | |||
|
|
|||
| result_table = test_table.agg_by(aggs, ["dumb"]) | |||
There was a problem hiding this comment.
Not part of this review, but I think the variable name dumb is "improper". I'd advise choosing completely "neutral" names commonly used (foo, bar, baz), or choose something "meaningful" such as key, or my_group. I'd suggest an audit of the client for other potentially "improper" names.
'dumb' is potentially offsensive thus improper to use in the code
devinrsmith
approved these changes
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also made it avaiable in deephaven2 via the agg.py wrapper