Add AutoService #1824
Merged
Add AutoService #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rcaudy
reviewed
Jan 13, 2022
|
Preferring to not push down into jpy just to minimize churn there. |
rcaudy
approved these changes
Jan 13, 2022
|
Indeed, it started as a service, then colin refactored it to not need to be a service anymore. Feel free to rename / delete as you see fit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a suggestion from @niloc132 in #1787, I decided to plumb AutoService for better maintainability and visibility into ServiceLoader services. This reduces the developer burden for creating the services files manually by using https://github.com/google/auto/tree/master/service - this is a compile/annotation-time-only dependency, no additional runtime dependencies. In addition, it likely fares better during refactoring, and provides immediate context to anybody looking at the code that this will be auto-discovered during runtime.
As part of the PR, I noticed that
open-api/lang-parser/src/main/resources/META-INF/services/io.deephaven.lang.parse.api.CompletionParseServiceis not a real service (maybe it used to be?).