Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in prep for end of month release of 0.9.0 #1841

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

devinrsmith
Copy link
Member

Fixes #1808

@@ -69,7 +69,7 @@ jobs:
tags: |
type=edge,branch=main
type=raw,priority=950,enable=${{ startsWith(github.ref, 'refs/heads/release/v') }},value=${{ steps.semver.outputs.semver }}
type=raw,enable=${{ startsWith(github.ref, 'refs/heads/release/v0.7') }},value=latest
type=raw,enable=${{ startsWith(github.ref, 'refs/heads/release/v0.9') }},value=latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are switching from 0.7 to 0.9, while others are switching from 0.8. Is there a reason why? And no way to share a constant using a matrix or an inputs context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was due to the previous PR for these straddling a release bump. There may be some better ways to use github action outputs, or scripting, but nothing built into the yaml afaict. #1808

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe inputs would work. Haven't used them before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, needs looks like it may be most appropriate. I'll create a ticket for improvement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devinrsmith devinrsmith merged commit 4617d7d into deephaven:main Jan 18, 2022
@devinrsmith devinrsmith deleted the bump-for-0-9-0 branch January 18, 2022 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The extended images should be tagged with latest
3 participants