Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exceptions on autocomplete #1876

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Avoid exceptions on autocomplete #1876

merged 3 commits into from
Jan 25, 2022

Conversation

niloc132
Copy link
Member

This patch fixes a case where the autocomplete would fail to get the
correct indent to suggest, and also reduces the log level for any
messages that can result from autocomplete errors.

Fixes #1196

@niloc132
Avoid exceptions on autocomplete
b3a0953 
This patch fixes a case where the autocomplete would fail to get the
correct indent to suggest, and also reduces the log level for any
messages that can result from autocomplete errors.

Fixes deephaven#1196
@niloc132 niloc132 added this to the Jan 2022 milestone Jan 24, 2022
@niloc132 niloc132 requested a review from mofojed January 24, 2022 22:24
@mofojed
Copy link
Member

mofojed commented Jan 25, 2022

The :open-api-lang-tools:test test is failing, run and make sure it passes locally before updating review

2022-01-24T22:44:06.8050211Z Cache saved successfully
2022-01-24T22:44:12.0996957Z 
2022-01-24T22:44:12.1001843Z > Task :open-api-lang-tools:test
2022-01-24T22:44:12.1003883Z 
2022-01-24T22:44:12.1008445Z ChunkerCompletionHandlerTest > Complex chains of methods on tables can parse #src sanely at any index > io.deephaven.lang.completion.ChunkerCompletionHandlerTest.Complex chains of methods on tables can parse 
2022-01-24T22:44:12.1012275Z t sanely at any index FAILED
2022-01-24T22:44:12.1016415Z     io.deephaven.base.verify.RequirementFailure at ChunkerCompletionHandlerTest.groovy:66
2022-01-24T22:44:12.1993351Z 
2022-01-24T22:44:12.2005465Z ChunkerCompletionHandlerTest > Complex chains of methods on tables can parse #src sanely at any index > io.deephaven.lang.completion.ChunkerCompletionHandlerTest.Complex chains of methods on tables can parse 
2022-01-24T22:44:12.2009695Z t  sanely at any index FAILED
2022-01-24T22:44:12.2013128Z     io.deephaven.base.verify.RequirementFailure at ChunkerCompletionHandlerTest.groovy:66
2022-01-24T22:44:12.2015087Z 
2022-01-24T22:44:12.2018713Z ChunkerCompletionHandlerTest > Complex chains of methods on tables can parse #src sanely at any index > io.deephaven.lang.completion.ChunkerCompletionHandlerTest.Complex chains of methods on tables can parse 
2022-01-24T22:44:12.2022151Z t = sanely at any index FAILED
2022-01-24T22:44:12.2026718Z     io.deephaven.base.verify.RequirementFailure at ChunkerCompletionHandlerTest.groovy:66

mofojed
mofojed requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix failing tests, otherwise looks good

@niloc132 niloc132 merged commit e769909 into deephaven:main Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
autocomplete NoDocumentationNeeded
Projects
None yet
Milestone
Jan 2022
Development

Successfully merging this pull request may close these issues.

Auto complete is unhappy when unexpected character is placed into document
2 participants
@niloc132 @mofojed