Quality of life improvements for formula handling around BigDecimal columns. #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcferretti
commented
Jan 27, 2022
jcferretti
commented
cpwright
requested changes
Jan 27, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageFunctionUtils.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageFunctionUtils.java
Show resolved
Hide resolved
cpwright
reviewed
Jan 28, 2022
There was a problem hiding this comment.
So I think you did a good job covering the functions. There is a question as to whether it makes sense to verify a few uses in a formula. I know you have it in the demo, but a handful of unit tests (less exhaustive) is still probably worth it to ensure we don't break e.g. the parser's handling of these things.
cpwright
previously approved these changes
Jan 28, 2022
…results for null values for those.
cpwright
approved these changes
Jan 28, 2022
|
Part of #1753 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.