Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish all jars #1929

Merged
merged 11 commits into from
Feb 25, 2022
Merged

Publish all jars #1929

merged 11 commits into from
Feb 25, 2022

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Feb 2, 2022

Publish DH jars

Includes a large refactoring, pushing root build.gradle logic into plugin conventions.

Each gradle project must declare a single io.deephaven.project.X plugin type.

Created combined-javadoc project (with configuration combinedJavadoc as output artifact).

Better lifecycle management of 'quick' as a subset of 'check'.

Fixes #1939

@devinrsmith devinrsmith added this to the Feb 2022 milestone Feb 2, 2022
@devinrsmith devinrsmith self-assigned this Feb 2, 2022
Includes a large refactoring, pushing root build.gradle logic into plugin conventions.

Each gradle project must declare a single io.deephaven.project.X plugin type.

Created combined-javadoc project.

Better lifecycle management of 'quick' as a subset of 'check'.

Fixes deephaven#1939
@devinrsmith
Copy link
Member Author

To audit the publication:

$ ./gradlew publishToMavenLocal -x sign
$ find ~/.m2/repository/io/deephaven -type f -wholename "**/0.10.0/**" -name "*.pom"

Copy link
Member

@JamesXNelson JamesXNelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I very much approve of these changes, and wish we did the same thing in enterprise.

}

if (!forkEvery) {
// NB: This comment may be outdated:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth removing rather than copy/pasting if we aren't sure it is accurate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running a test to see if this hack is still necessary - https://github.com/devinrsmith/deephaven-core/actions/runs/1849663443 . If these tests fail, or a lot longer than normal to run, I'd say the comment is valid and we need to leave the comment/logic (likely, follow up w/ a ticketed issue).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conclusion here? the linked build is stuck on the enterprise plugin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict, we can delete the forkEvery=32 hack; I've gotten a few successful nightly runs.

combined-javadoc/build.gradle Outdated Show resolved Hide resolved
SevenZip/build.gradle Outdated Show resolved Hide resolved
projects/test-configs/build.gradle Outdated Show resolved Hide resolved
fishconfig-local/build.gradle Outdated Show resolved Hide resolved
open-api/shared-ide/shared-ide.gradle Outdated Show resolved Hide resolved
settings.gradle Outdated
@@ -60,12 +57,17 @@ pyMods.each {
project(":$name").projectDir = file(dir)
}

include(':configs')
project(':configs').projectDir = file('projects/configs')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these have a kind of weird non-standard directory path?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the path of the configs "project". I just got rid of the extra layer of indirection that we had. If we want to move configs, test-configs to a different directory, or top level, we can.

@devinrsmith
Copy link
Member Author

Fork every follow up #2037

@devinrsmith devinrsmith merged commit 00a14c1 into deephaven:main Feb 25, 2022
@devinrsmith devinrsmith deleted the publish-all-jars branch February 25, 2022 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish DH jars
5 participants