-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish all jars #1929
Publish all jars #1929
Conversation
Includes a large refactoring, pushing root build.gradle logic into plugin conventions. Each gradle project must declare a single io.deephaven.project.X plugin type. Created combined-javadoc project. Better lifecycle management of 'quick' as a subset of 'check'. Fixes deephaven#1939
38d6de2
to
df26979
Compare
To audit the publication: $ ./gradlew publishToMavenLocal -x sign
$ find ~/.m2/repository/io/deephaven -type f -wholename "**/0.10.0/**" -name "*.pom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I very much approve of these changes, and wish we did the same thing in enterprise.
buildSrc/src/main/groovy/io.deephaven.java-common-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-jacoco-conventions.gradle
Outdated
Show resolved
Hide resolved
} | ||
|
||
if (!forkEvery) { | ||
// NB: This comment may be outdated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth removing rather than copy/pasting if we aren't sure it is accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running a test to see if this hack is still necessary - https://github.com/devinrsmith/deephaven-core/actions/runs/1849663443 . If these tests fail, or a lot longer than normal to run, I'd say the comment is valid and we need to leave the comment/logic (likely, follow up w/ a ticketed issue).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conclusion here? the linked build is stuck on the enterprise plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict, we can delete the forkEvery=32 hack; I've gotten a few successful nightly runs.
buildSrc/src/main/groovy/io.deephaven.java-test-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-test-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-header-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-license-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-test-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-jar-conventions.gradle
Outdated
Show resolved
Hide resolved
settings.gradle
Outdated
@@ -60,12 +57,17 @@ pyMods.each { | |||
project(":$name").projectDir = file(dir) | |||
} | |||
|
|||
include(':configs') | |||
project(':configs').projectDir = file('projects/configs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these have a kind of weird non-standard directory path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the path of the configs "project". I just got rid of the extra layer of indirection that we had. If we want to move configs, test-configs to a different directory, or top level, we can.
Fork every follow up #2037 |
Publish DH jars
Includes a large refactoring, pushing root build.gradle logic into plugin conventions.
Each gradle project must declare a single io.deephaven.project.X plugin type.
Created combined-javadoc project (with configuration combinedJavadoc as output artifact).
Better lifecycle management of 'quick' as a subset of 'check'.
Fixes #1939