Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reverse viewport logic on BarrageSnapshotRequest and BarrageSubscriptionRequest #1968

Merged
merged 24 commits into from
Feb 28, 2022
Merged

Implement reverse viewport logic on BarrageSnapshotRequest and BarrageSubscriptionRequest #1968

merged 24 commits into from
Feb 28, 2022

Conversation

lbooker42
Copy link
Contributor

Barrage 0.4.0 release added reverseViewport options to BarrageSnapshotRequest and BarrageSubscriptionRequest. Update server logic to implement these missing features.

@lbooker42 lbooker42 self-assigned this Feb 10, 2022
@lbooker42 lbooker42 added this to the Feb 2022 milestone Feb 10, 2022
@lbooker42 lbooker42 linked an issue Feb 10, 2022 that may be closed by this pull request
"Reverse Viewport" support in the Deephaven server and Java client #1946
Closed
rcaudy
rcaudy reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review of RowSet and WritableRowSetImpl.

engine/rowset/src/main/java/io/deephaven/engine/rowset/RowSet.java Outdated Show resolved Hide resolved
engine/rowset/src/main/java/io/deephaven/engine/rowset/RowSet.java Outdated Show resolved Hide resolved
engine/rowset/src/main/java/io/deephaven/engine/rowset/impl/WritableRowSetImpl.java Outdated Show resolved Hide resolved
engine/rowset/src/main/java/io/deephaven/engine/rowset/impl/WritableRowSetImpl.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covers ConstructSnapshot.

engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Feb 23, 2022
View reviewed changes
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshot.java Outdated Show resolved Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscription.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/uri/BarrageTableResolver.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/uri/BarrageTableResolver.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/uri/BarrageTableResolver.java Outdated Show resolved Hide resolved
server/src/test/java/io/deephaven/server/barrage/BarrageMessageRoundTripTest.java Outdated Show resolved Hide resolved
engine/rowset/src/main/java/io/deephaven/engine/rowset/impl/WritableRowSetImpl.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/util/ShiftInversionHelper.java Outdated Show resolved Hide resolved
@lbooker42 lbooker42 merged commit 05c79ad into deephaven:main Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
@lbooker42 lbooker42 deleted the lab-reverse-viewport branch June 26, 2024 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy left review comments

@nbauernfeind nbauernfeind nbauernfeind approved these changes

Assignees

@lbooker42 lbooker42

Labels
DocumentationNeeded
Projects
None yet
Milestone
Feb 2022
Development

Successfully merging this pull request may close these issues.

"Reverse Viewport" support in the Deephaven server and Java client
3 participants
@lbooker42 @nbauernfeind @rcaudy