Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft a4 group and aggregate #1992

Merged
merged 8 commits into from
Mar 14, 2022
Merged

first draft a4 group and aggregate #1992

merged 8 commits into from
Mar 14, 2022

Conversation

jakemulf
Copy link
Contributor

No description provided.

Let's start again by simulating some real-time data. This time we'll use a shorter time interval.

```python
time_interval = expressionToNanos("T1S")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you have the imports so this works encase they don't do the prior one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about that and I think you're right. I'll change this (and the other notebooks) to be more verbose

agg.AggCount("CharacterCount")
])
character_counts = daily_data.aggBy(character_count_agg, "Character")
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have some combined aggregations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can add another one that's a combined aggregation

Base automatically changed from time-series-pete-feedback to demo February 18, 2022 10:30
jakemulf and others added 2 commits February 22, 2022 09:24
* A5 if-then conditionals

* Apply suggestions from code review

* A6 time methods first draft (#2060)

* A6 time methods first draft

* Apply suggestions from code review

Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>

* code review updates

* applied code review comment to other notebooks

* Apply suggestions from code review

Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>

Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
@jakemulf jakemulf merged commit afc0581 into demo Mar 14, 2022
@jakemulf jakemulf deleted the a4-group-and-aggregate branch March 14, 2022 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants