-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create uri.py to wrap ResolveTools #2031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipkent
requested changes
Feb 25, 2022
devinrsmith
reviewed
Feb 25, 2022
jmao-denver
force-pushed
the
feature-2030
branch
from
March 2, 2022 04:38
58c8f8a
to
5bc8294
Compare
devinrsmith
reviewed
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's helpful to separate out logical changes vs style changes in the future.
chipkent
requested changes
Mar 4, 2022
jmao-denver
force-pushed
the
feature-2030
branch
from
March 4, 2022 17:55
aba80bd
to
db35468
Compare
chipkent
requested changes
Mar 8, 2022
chipkent
requested changes
Mar 28, 2022
chipkent
approved these changes
Mar 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new home for the functionality
Better doc
Fixes #2030