Discard listener for incremental release filters to avoid python holding it forever. #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
previously approved these changes
Feb 28, 2022
cpwright
changed the title
jcferretti
previously approved these changes
Mar 1, 2022
jcferretti
approved these changes
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we are done releasing rows incrementally, we should drop the reference from the filter to the listener. A heap dump showed a global JNI reference to the filter, which then held onto the listener, which in turn held onto the filtered table, which held onto its parent that contained gigabytes of selected data. With this change I can run more incremental tests in a single container without restarting it.
Additionally, by requesting a refresh from our terminal notifications we can eliminate the inter cycle gap, which can distort tests that are fairly quick by doing nothing between cycles (e.g., a "2 second" test may end up with almost a second of wait time after the initial release.