-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support growing
viewports for subscriptions
#2068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscription.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still looking more at BMP, but wanted to get you these comments.
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Show resolved
Hide resolved
...client/barrage-examples/src/main/java/io/deephaven/client/examples/SubscribeExampleBase.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments about comments.
No description provided.