Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support growing viewports for subscriptions #2068

Merged
merged 28 commits into from
Apr 11, 2022
Merged

Support growing viewports for subscriptions #2068

merged 28 commits into from
Apr 11, 2022

Conversation

lbooker42
Copy link
Contributor

No description provided.

@lbooker42 lbooker42 added this to the Mar 2022 milestone Mar 4, 2022
@lbooker42 lbooker42 self-assigned this Mar 9, 2022
lbooker42
lbooker42 commented Mar 9, 2022
View reviewed changes
Copy link
Contributor Author

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@lbooker42 lbooker42 linked an issue Mar 9, 2022 that may be closed by this pull request
"Growing" subscription support in the server-side implementation for Barrage #1947
Closed
nbauernfeind
nbauernfeind reviewed Mar 16, 2022
View reviewed changes
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java Outdated Show resolved Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscription.java Outdated Show resolved Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java Outdated Show resolved Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
lbooker42
lbooker42 commented Mar 22, 2022
View reviewed changes
Copy link
Contributor Author

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

nbauernfeind
nbauernfeind reviewed Mar 30, 2022
View reviewed changes
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still looking more at BMP, but wanted to get you these comments.

java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java Show resolved Hide resolved
...client/barrage-examples/src/main/java/io/deephaven/client/examples/SubscribeExampleBase.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments about comments.

server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
@lbooker42 lbooker42 merged commit 948cdca into deephaven:main Apr 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
@lbooker42 lbooker42 deleted the lab-grow-viewport branch June 26, 2024 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbauernfeind nbauernfeind nbauernfeind left review comments

@rcaudy rcaudy rcaudy approved these changes

Assignees

@lbooker42 lbooker42

Labels
NoDocumentationNeeded
Projects
None yet
Milestone
Mar 2022
Development

Successfully merging this pull request may close these issues.

"Growing" subscription support in the server-side implementation for Barrage
3 participants
@lbooker42 @nbauernfeind @rcaudy