Don't keep hard references to Table #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Mar 31, 2022
There was a problem hiding this comment.
Seems like a lot of code for the state machines, etc. That said, I think it does a pretty good job of cleaning up the reachability and liveness issues, and it's overall simpler/more obviously correct.
I'm a little concerned that @nbauernfeind mentioned we might have liveness issues with Java applications. I assume Groovy or Python get executed as scripts using the session's LivenessScope. That is arguably out-of-scope for this PR, however.
server/src/main/java/io/deephaven/server/appmode/ApplicationServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/appmode/ApplicationServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/appmode/ApplicationServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Apr 1, 2022
server/src/main/java/io/deephaven/server/appmode/ApplicationServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/appmode/ApplicationServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/appmode/ApplicationServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Apr 1, 2022
nbauernfeind
previously approved these changes
Apr 1, 2022
engine/table/src/main/java/io/deephaven/stream/StreamToTableAdapter.java
Show resolved
Hide resolved
rcaudy
reviewed
Apr 2, 2022
engine/table/src/main/java/io/deephaven/stream/StreamToTableAdapter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/stream/StreamToTableAdapter.java
Show resolved
Hide resolved
rcaudy
approved these changes
Apr 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130
Co-authored-by: Ryan Caudy ryan@deephaven.io