Rename deephaven2->deephaven #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmao-denver
commented
Apr 1, 2022
jmao-denver
commented
- gradle scripts still use names like deephaven-wheel, deephaven2-wheel, needs help from either @niloc132 or @devinrsmith to rename them properly
- pydocs for deephaven2 are missing the Kafka modules and the proper overview page from README #2062 will follow after this gets merged
niloc132
reviewed
Apr 1, 2022
Generators/src/main/java/io/deephaven/plot/util/GeneratePyV2FigureAPI.java
Show resolved
Hide resolved
niloc132
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Approved, I ignored all json files, and only read the contents of the .py and .java changes. I had a few small questions about the changes that weren't just import fixes, but Jianfeng has clarified, I'm good with it.
Gradle, docker, and codegen fixes will be a followup that Jianfeng will file (and either handle himself with help from me/devin, or assign to one of us).
devinrsmith
approved these changes
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.