Add cdc module in the new Python API #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
requested changes
Apr 6, 2022
jcferretti
approved these changes
Apr 6, 2022
| to the org.apache.kafka.clients.consumer.KafkaConsumer constructor; pass any KafkaConsumer specific desired | ||
| configuration here. Note this should include the relevant property for a schema server URL where the key | ||
| and/or value Avro necessary schemas are stored. | ||
| cdc_spec (CDCSpec): a CDCSpec obtained from calling either the cdc_short_spec or the cdc_short_spec function |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing the tests for this feature, but considering the complexity of setting up the testing environment, such omission is acceptable especially work on the follow-up #2182 will directly use the new module and thus adequately test it.
Fixes #2190