Add a ring table #2220
Merged
Add a ring table #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests forthcoming. |
rcaudy
reviewed
Apr 8, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/RingTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/RingTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AddsToRingsListener.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AddsToRingsListener.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AddsToRingsListener.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Apr 18, 2022
| @@ -373,6 +373,11 @@ def base64Fingerprint(source): | |||
| return _java_type_.base64Fingerprint(source) | |||
|
|
|||
|
|
|||
| @_passThrough | |||
| def booleanCol(name, *data): | |||
| return _java_type_.booleanCol(name, *data) | |||
There was a problem hiding this comment.
Seems like this is missing documentation, relative to its peers. Also, it's notably different (not wrapping _custom_booleanCol).
There was a problem hiding this comment.
So, this code is actually the correct implementation - the custom ones are for primitives. The missing pydoc is because I didn't follow-up with some .json changes (check fails if the python method booleanCol is missing, but not if the pydoc is "wrong"). Since we are axing legacy shortly, I figure it's better to not change hundreds of files (other small doc changes have been accumulating, but nobody has re-run the python generator); and leave as-is?
There was a problem hiding this comment.
Or you could re-run the generator? This is my (paranoid) pre-commit script:
./gradlew :replication-static:replicateAllSafe
./gradlew :replication-reflective:replicateAll
./gradlew spotlessApply
rm -r Integrations/python/deephaven/doc/*
./gradlew :Generators:generateAllPython
./gradlew :Generators:groovyStaticImportGenerator
./gradlew spotlessApply
engine/rowset/src/test/java/io/deephaven/engine/rowset/impl/RowSetTstUtils.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ArraySourceHelper.java
Outdated
Show resolved
Hide resolved
...e/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/ObjectRingChunkSource.java
Show resolved
Hide resolved
...ble/src/test/java/io/deephaven/engine/table/impl/sources/ring/DoubleRingChunkSourceTest.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/RingTableTools.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Show resolved
Hide resolved
rcaudy
reviewed
Apr 18, 2022
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Apr 19, 2022
| fillRingFromMiddle(source, chunk, fillContext, it, fillStartIx, appendChunkSize); | ||
| fillRingFromStart(source, chunk, fillContext, it, fillStartIx, appendChunkSize); | ||
| } | ||
| nextRingIx += logicalFillSize; | ||
| } | ||
|
|
||
| private void skipRows(Iterator it, long skipKey, long expectedDistance) { |
rcaudy
approved these changes
Apr 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.