-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ring table #2220
Add a ring table #2220
Conversation
Unit tests forthcoming. |
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/RingTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/RingTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AddsToRingsListener.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AddsToRingsListener.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AddsToRingsListener.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
@@ -373,6 +373,11 @@ def base64Fingerprint(source): | |||
return _java_type_.base64Fingerprint(source) | |||
|
|||
|
|||
@_passThrough | |||
def booleanCol(name, *data): | |||
return _java_type_.booleanCol(name, *data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is missing documentation, relative to its peers. Also, it's notably different (not wrapping _custom_booleanCol
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this code is actually the correct implementation - the custom ones are for primitives. The missing pydoc is because I didn't follow-up with some .json changes (check fails if the python method booleanCol is missing, but not if the pydoc is "wrong"). Since we are axing legacy shortly, I figure it's better to not change hundreds of files (other small doc changes have been accumulating, but nobody has re-run the python generator); and leave as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you could re-run the generator? This is my (paranoid) pre-commit script:
./gradlew :replication-static:replicateAllSafe
./gradlew :replication-reflective:replicateAll
./gradlew spotlessApply
rm -r Integrations/python/deephaven/doc/*
./gradlew :Generators:generateAllPython
./gradlew :Generators:groovyStaticImportGenerator
./gradlew spotlessApply
engine/rowset/src/test/java/io/deephaven/engine/rowset/impl/RowSetTstUtils.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ArraySourceHelper.java
Outdated
Show resolved
Hide resolved
...e/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/ObjectRingChunkSource.java
Show resolved
Hide resolved
...ble/src/test/java/io/deephaven/engine/table/impl/sources/ring/DoubleRingChunkSourceTest.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ring/RingTableTools.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/sources/ring/AbstractRingChunkSource.java
Outdated
Show resolved
Hide resolved
fillRingFromMiddle(source, chunk, fillContext, it, fillStartIx, appendChunkSize); | ||
fillRingFromStart(source, chunk, fillContext, it, fillStartIx, appendChunkSize); | ||
} | ||
nextRingIx += logicalFillSize; | ||
} | ||
|
||
private void skipRows(Iterator it, long skipKey, long expectedDistance) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static
?
No description provided.