Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with column names in PerformanceQueries.java; add py integration test for it. #2253

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Fix an issue with column names in PerformanceQueries.java; add py integration test for it. #2253

merged 2 commits into from
Apr 12, 2022

Conversation

jcferretti
Copy link
Member

Also, renamed

pyintegration/integration-tests/numbers_from_list_and_func.py

to include an _test suffix so that it would be picked up by the test run script (discussed and agreed with Colin).

@jcferretti jcferretti added this to the April 2022 milestone Apr 12, 2022
@jcferretti jcferretti self-assigned this Apr 12, 2022
jmao-denver
jmao-denver approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcferretti jcferretti merged commit c0315c0 into deephaven:main Apr 12, 2022
@jcferretti jcferretti deleted the cfs-perfmon-integration-test-0 branch April 12, 2022 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded
Projects
None yet
Milestone
Apr 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@jcferretti @jmao-denver