Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deephaven_legacy to not be installed #2267

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Apr 14, 2022

This will likely be removed soon, but in the meantime it would permit a user to install the deephaven and deephaven_server wheels to start the server from python without also installing deephaven_legacy.

Partial #2221

jmao-denver
jmao-denver previously approved these changes Apr 14, 2022
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is safe and future-proof.

py/server/deephaven/server/script_session/__init__.py Outdated Show resolved Hide resolved
@niloc132 niloc132 force-pushed the deephaven-py-without-legacy branch from 3a1fafd to 8fc25e0 Compare April 25, 2022 16:54
@niloc132 niloc132 merged commit 19fe5ee into deephaven:main Apr 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants